fix: gnokey sign should sign transactions
#1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
requested review from
jaekwon,
moul,
a team and
piux2
as code owners
zivkovicmilos
changed the title
gnokey sign signs transactionsgnokey sign should sign transactions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
+ Coverage 45.63% 48.24% +2.60%
==========================================
Files 480 408 -72
Lines 68817 62260 -6557
==========================================
- Hits 31408 30039 -1369
+ Misses 34795 29717 -5078
+ Partials 2614 2504 -110 ☔ View full report in Codecov by Sentry. |
ajnavarro
approved these changes
Apr 24, 2024
gfanton
approved these changes
Apr 24, 2024
thehowl
added a commit
that referenced
this pull request
Jun 6, 2024
This matches `gnokey sign`'s behaviour to the updated version from #1976. I've manually tested this on a local node, and it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the signing logic of
gnokey sign, to now actually sign a transaction if the user's signature is missing.Additionally, it cleans up the code, and adds coverage tests.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description